Skip to content

Conversation

@JavierGarciadeCastro
Copy link

PR description:
This PR adds some minor changes to the existing Scouting muon DQM framework. This framework consists of two plugins. The first plugin performs a tag and probe (T&P) method to monitor scouting muon and vertex distributions and efficiencies. The second plugin is designed to monitor distributions and efficiencies of muon L1 seeds.
Previously the T&P only monitored muons from the J/Psi, and this PR added muons from the Z boson.
This PR also changes the way we monitor the muon L1 seeds. Instead of processing all the L1 seeds together, we process Single Muon and Double Muon seeds separately, so that we can add different restrictions to each of these. We add the restriction of eta < 0.8 for the Single Muon seeds to improve efficiency.
The development of this code was presented in several meetings:
https://indico.cern.ch/event/1476209/
https://indico.cern.ch/event/1492373/
The implementation was built on top of CMSSW_15_1_0_pre2
PR validation:
We have checked out all dependencies and have a clean build. We applied the code-checks specified in PR #47235. Most runTheMatrix tests were successfully run as well, with a couple of errors coming from files not found:
runall-report-step123-.log

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 23, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @JavierGarciadeCastro for master.

It involves the following packages:

  • DQMOffline/HLTScouting (dqm)
  • HLTriggerOffline/Scouting (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @mtosi, @rociovilar this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Apr 24, 2025

test parameters:

  • workflow = 145.415

@mmusich
Copy link
Contributor

mmusich commented Apr 24, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9825e4/45692/summary.html
COMMIT: a7382bd
CMSSW: CMSSW_15_1_X_2025-04-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47938/45692/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 4007149
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 4007126
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 64.409 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 145.415 ): 64.409 KiB HLT/ScoutingOffline
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #47938 was updated. @antoniovagnerini, @cmsbuild, @rseidita can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Apr 24, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9825e4/45701/summary.html
COMMIT: eb4d972
CMSSW: CMSSW_15_1_X_2025-04-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47938/45701/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 4007149
  • DQMHistoTests: Total failures: 15
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 4007113
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 64.409 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 145.415 ): 64.409 KiB HLT/ScoutingOffline
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a3a532f into cms-sw:master Apr 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants